Warn when sending to already-used Bitcoin addresses #562

pull luke-jr wants to merge 14 commits into bitcoin-core:master from luke-jr:wallet_warn_reuse_gui changing 19 files +395 −31
  1. luke-jr commented at 7:40 PM on March 1, 2022: member

    Entering a used address in the GUI Send tab makes the field turn yellow. Sending to a used address from the GUI prompts with detailed information about prior usage, as well as a note about best practices to avoid address reuse.

    Continued from https://github.com/bitcoin/bitcoin/pull/15987 (significantly modified/rewritten - no more bloom filter)

    Depends on https://github.com/bitcoin/bitcoin/pull/22693 for non-GUI changes

  2. Wallet: Keep track of what addresses are used in wallet transactions (memory only) 698658e32f
  3. Wallet: Add fairly-efficient [negative] check that an address is not known to be used 2e2d887be1
  4. RPC/Wallet: Add "use_txids" to output of getaddressinfo 4a9a72b3eb
  5. Bugfix: Wallet: Don't initialise "used" flag for wallet tool "info" command
    Initialising "used" would otherwise incorrectly inflate the address book count beyond what was actually in the file
    8719b08475
  6. Merge branch 'getaddressinfo_txids' into wallet_warn_reuse_gui-22 4696dbfec4
  7. interfaces/wallet: Add checkAddressForUsage and findAddressUsage 3cce58ee48
  8. GUI: Add GUIUtil::dateStr add7f99b0d
  9. GUI: SendConfirmationDialog: Defer button setup until exec 0301e4ce06
  10. GUI: SendConfirmationDialog: Enable changing the actual buttons used
    Both buttons can be replaced with other standard buttons
    a73a126cf1
  11. GUI: WalletModel: Wrap checkAddressForUsage and findAddressUsage 3fd599686b
  12. GUI: QValidatedLineEdit: Add support for a warning-but-valid state c6a44687e9
  13. GUI: Implement BitcoinAddressUnusedInWalletValidator 621c794573
  14. GUI: Use warning indicator for send coins entries with reused addresses 390834fbab
  15. GUI: Add a warning prompt when sending to an already-used address ef823cdebd
  16. luke-jr marked this as a draft on Mar 1, 2022
  17. DrahtBot commented at 5:48 AM on March 2, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept ACK RandyMcMillan, Rspigler

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #555 (Restore Send button when using external signer by Sjors)
    • #553 (Change address / amount error background by w0xlt)
    • #537 (Point out position of invalid characters in Bech32 addresses by luke-jr)
    • #536 (Add address error location to GUI by meshcollider)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  18. hebasto added the label Wallet on Mar 10, 2022
  19. DrahtBot added the label Needs rebase on Mar 17, 2022
  20. DrahtBot commented at 7:23 AM on March 17, 2022: contributor

    <!--cf906140f33d8803c4a75a2196329ecb-->

    🐙 This pull request conflicts with the target branch and needs rebase.

    <sub>Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".</sub>

  21. RandyMcMillan commented at 5:16 PM on May 15, 2022: contributor

    Concept ACK

  22. Rspigler commented at 11:34 PM on June 27, 2022: contributor

    Concept ACK. Can test when taken out of Draft

  23. katesalazar commented at 9:52 AM on June 29, 2022: none

    Great idea, thanks. Hope doesn't break anything.

  24. DrahtBot commented at 10:30 AM on October 31, 2022: contributor

    <!--13523179cfe9479db18ec6c5d236f789-->There hasn't been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.
  25. DrahtBot commented at 12:50 AM on January 29, 2023: contributor

    <!--13523179cfe9479db18ec6c5d236f789-->

    There hasn't been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.
  26. hebasto commented at 3:14 PM on March 27, 2023: member

    Closing this due to lack of activity. Feel free to reopen.

  27. hebasto closed this on Mar 27, 2023
  28. bitcoin-core locked this on Mar 26, 2024
Contributors
luke-jrDrahtBotRandyMcMillanRspiglerkatesalazarhebasto
Labels
Needs rebaseWallet
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-02 00:44 UTC
Static mirror of GitHub issue/PR metadata (via 0xB10C github-metadata-backup), served from ryan.int.chaincode.com.