wallet, refactor: Make `WalletModel::sendCoins()` return `void` #608

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:220529-sendcoins changing 3 files +4 −13

hebasto commented at 3:50 PM on May 29, 2022: member

Currently, the WalletModel::sendCoins() function always returns the same value.

Also dead and noop (calling processSendCoinsReturn(OK)) code has been removed.

The other return statements have been removed from the WalletModel::sendCoins() function in bitcoin/bitcoin#17154 and bitcoin/bitcoin#17165.

qt, wallet, refactor: Make `WalletModel::sendCoins()` return `void`

Currently, the `WalletModel::sendCoins()` function always returns the
same value.

Also dead and noop code has been removed.

1f653dc262

hebasto added the label Refactoring on May 29, 2022
hebasto added the label Wallet on May 29, 2022
hebasto renamed this:
~~qt, wallet, refactor: Make `WalletModel::sendCoins()` return `void`~~
wallet, refactor: Make `WalletModel::sendCoins()` return `void`
on May 29, 2022
kristapsk approved
kristapsk commented at 4:18 PM on May 29, 2022: contributor

cr ACK 1f653dc2623ee2be3e1eeeaf5ce0e97966cecd6a
furszy approved
furszy commented at 6:07 PM on May 29, 2022: member

Code review ACK 1f653dc2

Reviewing this found https://github.com/bitcoin/bitcoin/pull/25239, so thanks for the push into the right direction hehe.
shaavan approved
shaavan commented at 7:44 AM on June 12, 2022: contributor
Code Review ACK 1f653dc2623ee2be3e1eeeaf5ce0e97966cecd6a
- It is an excellent cleanup, which eliminates a redundant return value and the need to check it under a conditional statement later.
Nice catch, @hebasto!
w0xlt approved
w0xlt commented at 10:12 AM on June 12, 2022: contributor

Code Review ACK https://github.com/bitcoin-core/gui/pull/608/commits/1f653dc2623ee2be3e1eeeaf5ce0e97966cecd6a
hebasto merged this on Jun 12, 2022
hebasto closed this on Jun 12, 2022
hebasto deleted the branch on Jun 12, 2022
sidhujag referenced this in commit b9797c7811 on Jun 13, 2022
bitcoin-core locked this on Jun 12, 2023

Contributors

Labels